Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geolocator_web]: Bump web from 0.5.1 to 1.0.0 in /geolocator_web #1547

Merged
merged 2 commits into from
Aug 5, 2024
Merged

[geolocator_web]: Bump web from 0.5.1 to 1.0.0 in /geolocator_web #1547

merged 2 commits into from
Aug 5, 2024

Conversation

l1qu1d
Copy link
Contributor

@l1qu1d l1qu1d commented Aug 2, 2024

[geolocator_web]: Bump web from 0.5.1 to 1.0.0 in /geolocator_web
chore: Update background color in geolocator examples, update Dart requirement to 3.4.0.

  • background is deprecated and shouldn't be used. Use surface instead. This feature was deprecated after v3.18.0-0.1.
  • Update to match package web change log:
    • Require Dart ^3.4.0.
    • APIs that return a double value now return double instead of num. This is to avoid users accidentally downcasting num, which has different semantics depending on whether you compile to JS or Wasm. See issue https://github.com/Baseflow/flutter-geolocator/pull/57[] for more details.

Fixes: #1543

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

l1qu1d added 2 commits August 2, 2024 14:27
chore: Update background color in geolocator examples

'background' is deprecated and shouldn't be used. Use surface instead. This feature was deprecated after v3.18.0-0.1.
- Require Dart ^3.4.0.
- APIs that return a double value now return double instead of num. This is to avoid users accidentally downcasting num, which has different semantics depending on whether you compile to JS or Wasm. See issue #57[] for more details.
@l1qu1d
Copy link
Contributor Author

l1qu1d commented Aug 3, 2024

PR ready for review at your convenience @mvanbeusekom. We need the PR to complete our migration to AutoRoute 9.0 as it depends on the package web: 1.0. Thanks!

@mvanbeusekom mvanbeusekom merged commit c07ac1c into Baseflow:main Aug 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants