Release plugin binding when activity is detached. (#1264)

Baseflow · Jan 16, 2024 · bb8e40a · bb8e40a
1 parent 978dbeb
commit bb8e40a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/permission_handler_android/CHANGELOG.md b/permission_handler_android/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 12.0.2
+
+* Fixes bug where Android activity is leaked when embedded in native Android application.
+
 ## 12.0.1
 
 * Fixes a bug where the `ignoreBatteryOptimizations` permission didn't report the correct status when the permission is requested and granted.

diff --git a/...android/android/src/main/java/com/baseflow/permissionhandler/PermissionHandlerPlugin.java b/...android/android/src/main/java/com/baseflow/permissionhandler/PermissionHandlerPlugin.java
@@ -75,7 +75,7 @@ public void onAttachedToActivity(@NonNull ActivityPluginBinding binding) {
             binding.getActivity()
         );
 
-        this.pluginBinding = binding;
+        pluginBinding = binding;
         registerListeners();
     }
 
@@ -87,8 +87,8 @@ public void onReattachedToActivityForConfigChanges(@NonNull ActivityPluginBindin
     @Override
     public void onDetachedFromActivity() {
         stopListeningToActivity();
-
         deregisterListeners();
+        pluginBinding = null;
     }
 
     @Override

diff --git a/permission_handler_android/pubspec.yaml b/permission_handler_android/pubspec.yaml
@@ -1,7 +1,7 @@
 name: permission_handler_android
 description: Permission plugin for Flutter. This plugin provides the Android API to request and check permissions.
 homepage: https://github.com/baseflow/flutter-permission-handler
-version: 12.0.1
+version: 12.0.2
 
 environment:
   sdk: ">=2.15.0 <4.0.0"