-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TargetApi annotation in PermissionUtils.java for Android #1122
Conversation
Hi @victorsanni, Can you elaborate why these changes are required? Both Android and iOS are building just fine at the moment and it seems that your changes break the build with the following error in CI:
|
On Android, not including the Same with the implicit fallthrough. I have reverted the iOS import changes and will move the fallthrough comment to its own PR. |
…w#1122) * added iOS imports * added java code style suggestions to PermissionUtils.java * fix PermissionHandlerEnums.h import in Codec.h * Edited pubspec.yaml and CHANGELOG.md files * Edited pubspec.yaml and CHANGELOG.md for android * fixed formatting error in android CHANGELOG * Remove iOS changes * Update CHANGELOG.md * Remove fall through comment in PermissionUtils.java --------- Co-authored-by: Maurits van Beusekom <[email protected]>
This adds the
TargetApi
annotation to thegetManifestNames
method inPermissionUtils.java
. On Android, not including the TargetApi annotation to the getManifestNames method in PermissionUtils.java causes StrictMode errors: https://developer.android.com/reference/android/os/StrictMode.List at least one fixed issue.
Pre-launch Checklist
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.md
to add a description of the change.///
).main
.dart format .
and committed any changes.flutter analyze
and fixed any errors.