Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Port Settings.canDrawOverlays (Android) #1216

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

JeroenWeener
Copy link
Contributor

Ports the necessary Android SDK bits for checking whether an application can draw over the screen.

In the process, duplicate code for Activity that is present in Context was removed as much as possible.

Closes https://github.com/orgs/Baseflow/projects/9/views/1?pane=issue&itemId=39927286.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto next.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much better like this when the Activity derived from Context

@JeroenWeener JeroenWeener merged commit d955c86 into Baseflow:next Nov 10, 2023
1 check failed
@JeroenWeener JeroenWeener deleted the feature/draw-overlays branch November 10, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants