Refactor: Port PermissionInfo related classes (Android)
#1219
Conversation
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
Thinking a bit ahead, I don't see we would need the binaryMessenger anywhere else except for the constructor of the class. The binaryMessenger should only be used to pass into Flutter API implementation classes and these are always created in the constructor. Therefore I feel we can remove this field (and also in already existing code).
Requires merge of #1218.
Ports the necessary Android SDK bits for checking which permissions have been requested.
There is no specific ticket for this issue, but it will be necessary for implementing an Android implementation of the platform interface using the ported Android SDK (which is tracked in https://github.com/orgs/Baseflow/projects/9/views/1?pane=issue&itemId=40148957).
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).next.dart format .and committed any changes.flutter analyzeand fixed any errors.