Refactor: Port Service related classes (Android) #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
requested changes
Nov 16, 2023
Comment on lines
21
to
23
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
This field can be removed, as the binaryMessenger will never be used outside the constructor of this class.
| * arguments of callbacks methods to a Dart instance. | ||
| */ | ||
| public class BluetoothManagerFlutterApiImpl { | ||
| // To ease adding additional methods, this value is added prematurely. |
There was a problem hiding this comment.
This field can be removed, as the binaryMessenger will never be used outside the constructor of this class.
Comment on lines
21
to
23
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
This field can be removed, as the binaryMessenger will never be used outside the constructor of this class.
Comment on lines
21
to
23
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
This field can be removed, as the binaryMessenger will never be used outside the constructor of this class.
Comment on lines
21
to
23
| // To ease adding additional methods, this value is added prematurely. | ||
| @SuppressWarnings({"unused", "FieldCanBeLocal"}) | ||
| private final BinaryMessenger binaryMessenger; |
There was a problem hiding this comment.
This field can be removed, as the binaryMessenger will never be used outside the constructor of this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the necessary Android SDK bits for checking service statuses and opening service settings.
Closes
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).next.dart format .and committed any changes.flutter analyzeand fixed any errors.