Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf:Optimize the status of READ_MEDIA_VISUAL_USER_SELECTED permission #1359

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

inTao
Copy link
Contributor

@inTao inTao commented Aug 14, 2024

I adjusted the return of permission status; Added Android version version judgment

@mvanbeusekom
Copy link
Member

Hi @inTao,

Would you mind updating the version in the pubspec.yaml file and add the change to the CHANGELOG.md (according to the conventions mentioned here) for the permission_handler_android package?

@inTao
Copy link
Contributor Author

inTao commented Aug 14, 2024

你好@inTao

您介意更新文件version中的内容pubspec.yaml并将更改添加到permission_handler_android 包中CHANGELOG.md(根据此处提到的约定)吗?

👌

@LulleBulle
Copy link
Contributor

Hello @inTao , have you run flutter analyze as per the contribution guide? It seems to fail in the pipeline.

@inTao
Copy link
Contributor Author

inTao commented Aug 15, 2024

Hello @inTao , have you run flutter analyze as per the contribution guide? It seems to fail in the pipeline.

Can I just ignore it? I don't think it was caused by this change
1723702643507

@mvanbeusekom
Copy link
Member

Hello @inTao , have you run flutter analyze as per the contribution guide? It seems to fail in the pipeline.

Can I just ignore it? I don't think it was caused by this change 1723702643507

No worries, I will fix them quickly before releasing these changes.

@mvanbeusekom mvanbeusekom merged commit b8d3182 into Baseflow:main Aug 16, 2024
1 check failed
@mvanbeusekom
Copy link
Member

@inTao, @LulleBulle, I have just released version 12.0.9 containing these changes. Thank you both for your helpful contributions.

dogiaplinh pushed a commit to dogiaplinh/flutter-permission-handler that referenced this pull request Sep 13, 2024
Baseflow#1359)

* perf:Optimize the status of READ_MEDIA_VISUAL_USER_SELECTED permission

* updata version to 12.0.9  added CHANGELOG

* Deal with other situations

* Remove non-essential check restricted states

---------

Co-authored-by: inTao <[email protected]>
Co-authored-by: inTao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants