Preexec as an updatedable library #1587
Conversation
Makefile to update vendors should maybe be a bash script. it is however only ment to be run by developers. Maybe vendors should be a git-subtree(1) instead Maybe we should always supply a bash-it-init.bash(or some other name) file to the vendoer forlder so we have a standardized way of loading vendor libs from bash_it.sh
|
I just synced my PR with the main branch. I have been using this for over an year now with no problems. |
|
Thanks for your PR! You've got some good stuff in this PR. Yeah, let's discuss. So far, I like the idea of |
| @egrep "^[0-9a-zA-Z\-]+:$$" Makefile | grep -v "help:" | ||
|
|
||
| update-preexec: | ||
| # - Maybe we should make this into a git-subtree(1) instead |
There was a problem hiding this comment.
I think this comment is on point- we should start using git-subtree for this kind of stuff
There was a problem hiding this comment.
I might have another idea I want to try before resorting to subtrees as they can also get a bit messy to work with.
|
|
||
| update-preexec: | ||
| # - Maybe we should make this into a git-subtree(1) instead | ||
| # - Maybe we should always supply a bash-it-init.bash file to the vendoer forlder so we have a |
There was a problem hiding this comment.
I also agree with this comment, this will make the loading way more clear and rebust
| # See "${BASH_IT}/vendors/Makefile for comments | ||
| for _bash_it_config_file in ${BASH_IT}/vendors/*/*.bash | ||
| do | ||
| source "$_bash_it_config_file" |
There was a problem hiding this comment.
you should add _log_debug here
|
I wanted to try out something a little different than this PR. So I have made a new one #1776 |
|
I think we have settled on #1776 being the better solution 😄 |
As per #1304 (comment)
I know it's not ready to merge but I thought we could have a discussion on how we would go about including libraries into bash-it
Personally I find git submodules a total nogo. They are a pain to work with especially if you start to have more than a few. Git subtress could work, but I think, for now, a simple Makefile (as in my PR) or a bash script will do.
We might also have to reconsider how we load these libraries into bash-it