Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: helper: cite plumbing metadata #1813

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

NoahGorny
Copy link
Member

Stumbled across this when I fixed a test in #1776

Description

Internal composure cites are missing from the tests, this causes some confusing and misleading errors when
loading bash-it files which uses those cites

Motivation and Context

This was pretty annoying, and I am happy to improve our tests

How Has This Been Tested?

locally

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@cornfeedhobo
Copy link
Member

yessssss. I have a branch that relates to this. I'd like to cleanup all the composure stuff. great start!

@NoahGorny NoahGorny merged commit 0d0fde9 into Bash-it:master Jan 28, 2021
@NoahGorny NoahGorny deleted the improve-test-helper branch January 28, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants