-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Rename ride
function to address issue #125
#126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thank you for your PR! I think it's a nice addition. 😄 I do have some nitpicks before merging though.
Also, the CI seems to be failing on linting. Having the CI succeed is required for merging as well.
Not nitpicking. I need the feedback to do a PR correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last 2 points. The rest looks and works great! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added the possibilty to rename a ride so you are able to give the ride a longer name than ingame. This can be benefitial in multiplayer servers to add textformat, like colour or font size to the names. (see issue #125)