Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rename ride function to address issue #125 #126

Merged
merged 12 commits into from
Nov 23, 2024

Conversation

Manticore-007
Copy link
Contributor

@Manticore-007 Manticore-007 commented Nov 16, 2024

I added the possibilty to rename a ride so you are able to give the ride a longer name than ingame. This can be benefitial in multiplayer servers to add textformat, like colour or font size to the names. (see issue #125)

image

Copy link
Owner

@Basssiiie Basssiiie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you for your PR! I think it's a nice addition. 😄 I do have some nitpicks before merging though.

Also, the CI seems to be failing on linting. Having the CI succeed is required for merging as well.

package-lock.json Outdated Show resolved Hide resolved
src/ui/mainWindow.ts Outdated Show resolved Hide resolved
src/ui/rideWindow.ts Outdated Show resolved Hide resolved
src/ui/rideWindow.ts Outdated Show resolved Hide resolved
src/ui/rideWindow.ts Outdated Show resolved Hide resolved
src/ui/rideWindow.ts Outdated Show resolved Hide resolved
@Manticore-007
Copy link
Contributor Author

I do have some nitpicks before merging though.

Not nitpicking. I need the feedback to do a PR correctly.

Copy link
Owner

@Basssiiie Basssiiie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last 2 points. The rest looks and works great! 😄

src/ui/rideWindow.ts Outdated Show resolved Hide resolved
src/ui/rideWindow.ts Outdated Show resolved Hide resolved
Copy link
Owner

@Basssiiie Basssiiie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Basssiiie Basssiiie merged commit 3ca540b into Basssiiie:main Nov 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants