Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-test paredit.backspace where start != end #2682

Conversation

pbwolf
Copy link

@pbwolf pbwolf commented Dec 28, 2024

What has changed?

A new unit test checks the first logic branch in paredit.backspce: a non-empty selection.

I suppose paredit.backspace works properly in practice, but the new test failed. The test's simulator (StringDocument) did not attend to the non-empty selection case and always removed one character. I gather EditableDocument.backspace is used only by paredit.backspace(?), so harmonizing it with the actual editor should be all right. Paredit backspace uses doc.backspace twice, under distinct circumstances, but the second usage was already trodden by unit tests.

Fixes #2681

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Beneath mention Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • (It does not) Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • n/a Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit 6375242
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/676fff9a95919c00085b54d6
😎 Deploy Preview https://deploy-preview-2682--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PEZ PEZ merged commit 5847336 into BetterThanTomorrow:dev Dec 29, 2024
5 checks passed
@PEZ
Copy link
Collaborator

PEZ commented Dec 29, 2024

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants