Unit-test paredit.backspace where start != end #2682
Merged
+14
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
A new unit test checks the first logic branch in paredit.backspce: a non-empty selection.
I suppose paredit.backspace works properly in practice, but the new test failed. The test's simulator (StringDocument) did not attend to the non-empty selection case and always removed one character. I gather EditableDocument.backspace is used only by paredit.backspace(?), so harmonizing it with the actual editor should be all right. Paredit backspace uses doc.backspace twice, under distinct circumstances, but the second usage was already trodden by unit tests.
Fixes #2681
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)Updated the[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.Added to or updated docs in this branch, if appropriatenpm run prettier-format
)npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik