-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Rails 7.1 - 8 support #141
Merged
rzane
merged 17 commits into
Betterment:master
from
argvniyx-enroute:argv/rails-7-1-plus-support
Jan 24, 2025
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
251b849
bundle update --bundler
argvniyx-enroute 07a12b2
drop rails 6.1 support
argvniyx-enroute 1baa1c5
drop pre ruby 3.2 support
argvniyx-enroute 5574d0a
swap rubocop deps for betterlint
argvniyx-enroute 85095f1
add Rails 7.1 appraisal
argvniyx-enroute fdd5d1a
add Rails 7.2 appraisal
argvniyx-enroute 4cca126
add Rails 8 appraisal
argvniyx-enroute 65079b3
have the Rails version range be closed
argvniyx-enroute 75e8d21
bundle update
argvniyx-enroute 071e0a8
bump version.rb
argvniyx-enroute 62c1261
don't pin concurrent-ruby for 7.1
argvniyx-enroute 40c2124
re-intro support for ruby 3.1
argvniyx-enroute d338dd7
exclude ruby 3.1 + Rails 8 combo
argvniyx-enroute fbda10a
add missed constraints on railties
argvniyx-enroute a1c6525
constrain zeitwerk
argvniyx-enroute 7d0c355
make zeitwerk a dev dependency
argvniyx-enroute bf020ce
use Rails::VERSION::STRING.to_f as arg to config.load_defaults
argvniyx-enroute File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,16 @@ | ||
appraise 'rails-6-1' do | ||
gem 'railties', '~> 6.1.0' | ||
end | ||
|
||
appraise 'rails-7-0' do | ||
gem 'concurrent-ruby', '1.3.4' | ||
gem 'railties', '~> 7.0.0' | ||
end | ||
|
||
appraise 'rails-7-1' do | ||
gem 'railties', '~> 7.1.0' | ||
end | ||
|
||
appraise 'rails-7-2' do | ||
gem 'railties', '~> 7.2.0' | ||
end | ||
|
||
appraise 'rails-8-0' do | ||
gem 'railties', '~> 8.0.0' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.1 is technically still supported for a couple months -- since this is an open source client I might be inclined to increment
required_ruby_version
more slowly and keep support for 3.1 unless it's too costly for us.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always exclude combinations in the matrix if 3.1 isn't compatible with newest Rails.