Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Rails 7.1 - 8 support #141

Merged
merged 17 commits into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: [3.0, 3.1, 3.2]
ruby: ["3.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.1 is technically still supported for a couple months -- since this is an open source client I might be inclined to increment required_ruby_version more slowly and keep support for 3.1 unless it's too costly for us.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always exclude combinations in the matrix if 3.1 isn't compatible with newest Rails.

gemfile:
- gemfiles/rails_6_1.gemfile
- gemfiles/rails_7_0.gemfile
- gemfiles/rails_7_1.gemfile
- gemfiles/rails_7_2.gemfile
- gemfiles/rails_8_0.gemfile
name: Ruby ${{ matrix.ruby }}, ${{ matrix.gemfile }}
steps:
- uses: technote-space/auto-cancel-redundant-job@v1
Expand Down
3 changes: 2 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ AllCops:
- 'vendor/**/*'
- 'spec/dummy/**/*'
- 'Gemfile'
- 'gemfiles/*.gemfile'
DisplayStyleGuide: true
DisplayCopNames: true
TargetRubyVersion: 3.0
TargetRubyVersion: 3.2

Layout/ParameterAlignment:
Enabled: false
Expand Down
17 changes: 13 additions & 4 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
appraise 'rails-6-1' do
gem 'railties', '~> 6.1.0'
end

appraise 'rails-7-0' do
gem 'concurrent-ruby', '1.3.4'
gem 'railties', '~> 7.0.0'
end

appraise 'rails-7-1' do
gem 'railties', '~> 7.1.0'
end

appraise 'rails-7-2' do
gem 'railties', '~> 7.2.0'
end

appraise 'rails-8-0' do
gem 'railties', '~> 8.0.0'
end
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
source "https://rubygems.org"
ruby '>= 2.7.0'

# Required for, e.g., show.json.jbuilder to work
# see: https://github.com/rails/jbuilder/issues/346
Expand Down
Loading
Loading