Add Rails 7.1 support #6
Conversation
argvniyx-enroute
force-pushed
the
argv/main/add-rails-7-1-support
branch
2 times, most recently
from
ba1fe88 to
2d297c7
Compare
I couldn't get this to run locally, because `tasks += ...` would complain about tasks being nil.
I think this is what's tripping CI up; we try to connect to the database and then create it. I think we intended to only do `create` and then `connect` (?)
I'd expect CI to show me this trace, so this might not be it, but when trying `bin/rails db:create` locally the whole thing failed because `config.assets...` comes from sprockets-rails, which is no longer bundled by default 🤷. Maybe unblocking this allows us to create the database (?)
argvniyx-enroute
force-pushed
the
argv/main/add-rails-7-1-support
branch
2 times, most recently
from
557d831 to
84ddca0
Compare
this accomplished nothing :-(
argvniyx-enroute
force-pushed
the
argv/main/add-rails-7-1-support
branch
from
84ddca0 to
12eb529
Compare
argvniyx-enroute
force-pushed
the
argv/main/add-rails-7-1-support
branch
from
12eb529 to
97cadc0
Compare
| @@ -43,7 +44,7 @@ jobs: | |||
| options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
As I was trying to figure out why things failed, I figured I might as well align this to other yml files.
| @@ -32,6 +32,7 @@ if (Rails.env.development? || Rails.env.test?) && defined? Dummy | |||
|
|
|||
| task(:default).clear | |||
| if ENV['APPRAISAL_INITIALIZED'] || ENV['CI'] | |||
| tasks = [:spec] | |||
There was a problem hiding this comment.
All this time.......we weren't actually running tests in CI (!) This would fail silently afaict. I stumbled upon this by trying to run be rake locally.
| username: <%= ENV['POSTGRES_USER'] %> | ||
| host: localhost |
There was a problem hiding this comment.
CI failed on me god knows how many times because I couldn't figure out how to configure this. This worked, but I think any combination of username/password or username POSTGRES_HOST_AUTH_METHOD=true would as long as we set host here. LMK if there's a better way to do this (since I mostly went with existing configs in other gems)
| @@ -27,16 +27,16 @@ | |||
| # Debug mode disables concatenation and preprocessing of assets. | |||
| # This option may cause significant delays in view rendering with a large | |||
| # number of complex assets. | |||
| config.assets.debug = true | |||
| # config.assets.debug = true | |||
There was a problem hiding this comment.
I couldn't run bundle exec rails console because rails no longer includes sprockets-rails by default, and this fails. I can get rid of these, if you'd like.
i think i added that code. it's strange but basically once upon a time i needed the first one to connect to the db and then the second one to reconnect after creating the database. maybe it doesn't need to happen anymore? i'm fine to try cleaning that up.
nope! remove it! |
/task https://app.asana.com/0/1205835826533561/1205835897803467/f
This adds Rails 7.1 support and then some. I'll try to explain inline. Empty lines were added by running
rubocopafter adding the 7.1 gemfile.Qs:
establish_connectioncalls here?with_transactional_lock/spec/spec_helper.rb
Lines 8 to 10 in e7d84e9
travisdependency anymore? Got rid of it bc the Rails 7.1 gemfile test would fail with a Faraday related error, and I saw that Faraday's pulled in bytravis.