refactor: refactor chain reorgs handling #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJColombo
force-pushed
the
refactor/reorgs-handling
branch
from
58a052c to
4144f4b
Compare
PJColombo
force-pushed
the
refactor/reorgs-handling
branch
3 times, most recently
from
4c0762e to
9040406
Compare
PabloCastellano
approved these changes
Jun 20, 2024
…lock root hashes instead of listening to `chain_reorg` sse event
PJColombo
force-pushed
the
refactor/reorgs-handling
branch
from
9040406 to
36577be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the indexer's reorg handling logic.
Previously, the indexer subscribed to the beacon node’s SSE stream to listen for
chain_reorgevents. The issue with this approach was the delay in event notification, causing the indexer to call the Blobscan API’s reorg handling endpoint after the reorg had already occurred.The indexer now detects reorgs by comparing the parent root of the head block with the root of the last indexed block. If there is a mismatch, it indicates a reorg, and the indexer handles it immediately.