Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add procedure for upserting weaveVM blob storage references #683

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

PJColombo
Copy link
Member

@PJColombo PJColombo commented Jan 14, 2025

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

This PR introduces a new protected endpoint that upserts WeaveVM blob storage references based on a provided set of versioned blob hashes.

Motivation and Context (Optional)

The endpoint is designed for use by the WeaveVM Blobscan service after blobs are persisted in WeaveVM.

Related Issue (Optional)

Screenshots (if appropriate):

Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: d714ab3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@blobscan/api Minor
@blobscan/rest-api-server Patch
@blobscan/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 2:00pm
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 2:00pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 2:00pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 2:00pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 2:00pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 2:00pm

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 95.39474% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.50%. Comparing base (e1421f6) to head (d714ab3).

Files with missing lines Patch % Lines
packages/api/src/utils/auth.ts 87.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   87.47%   88.50%   +1.03%     
==========================================
  Files         159      160       +1     
  Lines       10990    10917      -73     
  Branches     1184     1199      +15     
==========================================
+ Hits         9613     9662      +49     
+ Misses       1377     1255     -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 332.51 KB (🔴 +86.89 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 332.75 KB 95.07%
/stats 348.26 KB 680.77 KB 194.51%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 355.55 KB 688.06 KB 196.59% (🟢 -3.94%)
/address/[address] 30.17 KB 362.68 KB 103.62% (🟢 -3.87%)
/blob/[hash] 30.51 KB 363.02 KB 103.72% (🟢 -3.40%)
/blobs 81.32 KB 413.83 KB 118.24% (🟡 +13.85%)
/block/[id] 15.58 KB 348.08 KB 99.45% (🟢 -3.79%)
/blocks 78.49 KB 411 KB 117.43% (🟡 +13.69%)
/tx/[hash] 18.85 KB 351.36 KB 100.39% (🟡 +1.60%)
/txs 77.9 KB 410.41 KB 117.26% (🟡 +11.66%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Collaborator

@xFJA xFJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@PJColombo PJColombo changed the base branch from main to feat/add-weavevm-support January 15, 2025 13:40
@PJColombo PJColombo changed the base branch from feat/add-weavevm-support to main January 15, 2025 13:40
@PJColombo PJColombo force-pushed the feat/api/weavevm-endpoint branch from e8b3790 to 2936d0b Compare January 15, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants