Bookingsync

.github/workflows/ci.yml

@@ -0,0 +1,23 @@
+name: CI
+on: [pull_request]
+jobs:
+  rspec:
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - { ruby: '3.0', rails: '6.0' }
+          - { ruby: '3.0', rails: '6.1' }
+          - { ruby: '3.0', rails: '7.0' }
+          - { ruby: '3.1', rails: '7.0' }
+          - { ruby: '3.2', rails: '7.0' }
+    runs-on: ubuntu-latest
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails.${{ matrix.rails }}.gemfile
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - run: bundle exec rake test:units

.travis.yml

@@ -2,26 +2,32 @@ language: ruby
 script: "bundle exec rake test:units"
 sudo: false
 cache: bundler
+before_install:
+  # https://github.com/travis-ci/travis-ci/issues/8978#issuecomment-354036443
+  - gem update --system
+  - gem install bundler
 
 rvm:
-- 2.0
-- 2.1
-- 2.2.3
+- 2.6.5
+- 2.5
+- 2.4
+- 2.3
 
 gemfile:
-- Gemfile.rails32
-- Gemfile.rails40
-- Gemfile.rails41
+- Gemfile.rails60
+- Gemfile.rails52
+- Gemfile.rails51
+- Gemfile.rails50
 - Gemfile.rails42
-- Gemfile.rails5
 
 matrix:
   exclude:
-    - rvm: 2.0
-      gemfile: Gemfile.rails5
-    - rvm: 2.1
-      gemfile: Gemfile.rails5
+    - rvm: 2.3
+      gemfile: Gemfile.rails60
+    - rvm: 2.4
+      gemfile: Gemfile.rails60
 
 notifications:
   email:
-  - [email protected]
+    on_success: never
+    on_failure: always

Appraisals

@@ -0,0 +1,5 @@
+%w[6.0 6.1 7.0].each do |version|
+  appraise "rails.#{version}" do
+    gem "activesupport", "~> #{version}.0"
+  end
+end

CONTRIBUTING.md

@@ -27,12 +27,7 @@ When submitting a pull request to resolve an issue:
 
 ## Gateway Placement within Shopify
 
-The addition of your gateway to active_merchant does not guarantee placement within Shopify. In order to have your gateway considered, please send an email to [email protected] with **Active_Merchant Integration** in the subject. Be sure to include:
-
-1. Name, URL & description of the payment provider you wish to integrate
-2. Markets served by this integration
-3. List of major supported payment methods
-4. Your most recent Certificate of PCI Compliance
+Placement within Shopify is available by invitation only at this time.
 
 ## Version/Release Management
 

Gemfile

@@ -5,5 +5,5 @@ gem 'jruby-openssl', :platforms => :jruby
 
 group :test, :remote_test do
   # gateway-specific dependencies, keeping these gems out of the gemspec
-  gem 'braintree', '>= 2.50.0'
+  gem 'braintree', '>= 2.78.0'
 end

Gemfile.rails42

@@ -5,7 +5,7 @@ gem 'jruby-openssl', :platforms => :jruby
 
 group :test, :remote_test do
   # gateway-specific dependencies, keeping these gems out of the gemspec
-  gem 'braintree', '>= 2.50.0'
+  gem 'braintree', '~> 2.78.0'
 end
 
-gem 'rails', '~> 4.2.0'
+gem 'activesupport', '~> 4.2.0'

Gemfile.rails41 → Gemfile.rails50

@@ -5,7 +5,7 @@ gem 'jruby-openssl', :platforms => :jruby
 
 group :test, :remote_test do
   # gateway-specific dependencies, keeping these gems out of the gemspec
-  gem 'braintree', '>= 2.50.0'
+  gem 'braintree', '~> 2.78.0'
 end
 
-gem 'rails', '~> 4.1.0'
+gem 'activesupport', '~> 5.0.0'

Gemfile.rails5 → Gemfile.rails51

@@ -5,9 +5,7 @@ gem 'jruby-openssl', :platforms => :jruby
 
 group :test, :remote_test do
   # gateway-specific dependencies, keeping these gems out of the gemspec
-  gem 'braintree', '>= 2.50.0'
+  gem 'braintree', '~> 2.78.0'
 end
 
-gem 'rails', github: 'rails/rails'
-gem 'arel', github: 'rails/arel'
-gem 'rack', github: 'rack/rack'
+gem 'activesupport', '~> 5.1.0'

Gemfile.rails52

@@ -0,0 +1,11 @@
+source 'https://rubygems.org'
+gemspec
+
+gem 'jruby-openssl', :platforms => :jruby
+
+group :test, :remote_test do
+  # gateway-specific dependencies, keeping these gems out of the gemspec
+  gem 'braintree', '~> 2.78.0'
+end
+
+gem 'activesupport', '~> 5.2.0.rc1'

Gemfile.rails32 → Gemfile.rails60

@@ -5,7 +5,7 @@ gem 'jruby-openssl', :platforms => :jruby
 
 group :test, :remote_test do
   # gateway-specific dependencies, keeping these gems out of the gemspec
-  gem 'braintree', '>= 2.50.0'
+  gem 'braintree', '~> 2.78.0'
 end
 
-gem 'rails', '~> 3.2.0'
+gem 'activesupport', '~> 6.0'

Gemfile.rails40 → Gemfile.rails70

@@ -5,7 +5,7 @@ gem 'jruby-openssl', :platforms => :jruby
 
 group :test, :remote_test do
   # gateway-specific dependencies, keeping these gems out of the gemspec
-  gem 'braintree', '>= 2.50.0'
+  gem 'braintree', '~> 2.78.0'
 end
 
-gem 'rails', '~> 4.0.0'
+gem 'activesupport', '~> 7.0'

README.md

@@ -91,7 +91,6 @@ The [ActiveMerchant Wiki](http://github.com/activemerchant/active_merchant/wikis
 * [Bank Frick](http://www.bankfrickacquiring.com/) - LI, US
 * [Banwire](http://www.banwire.com/) - MX
 * [Barclays ePDQ Extra Plus](http://www.barclaycard.co.uk/business/accepting-payments/epdq-ecomm/) - GB
-* [Barclays ePDQ MPI](http://www.barclaycard.co.uk/business/accepting-payments/epdq-mpi/) - GB
 * [Be2Bill](http://www.be2bill.com/) - FR
 * [Beanstream.com](http://www.beanstream.com/) - CA, US
 * [BluePay](http://www.bluepay.com/) - US
@@ -150,7 +149,7 @@ The [ActiveMerchant Wiki](http://github.com/activemerchant/active_merchant/wikis
 * [Metrics Global](http://www.metricsglobal.com) - US
 * [MasterCard Internet Gateway Service (MiGS)](http://mastercard.com/mastercardsps) - AU, AE, BD, BN, EG, HK, ID, IN, JO, KW, LB, LK, MU, MV, MY, NZ, OM, PH, QA, SA, SG, TT, VN
 * [Modern Payments](http://www.modpay.com) - US
-* [MONEI](http://www.monei.net/) - ES
+* [MONEI](http://www.monei.net/) - AD, AT, BE, BG, CA, CH, CY, CZ, DE, DK, EE, ES, FI, FO, FR, GB, GI, GR, HU, IE, IL, IS, IT, LI, LT, LU, LV, MT, NL, NO, PL, PT, RO, SE, SI, SK, TR, US, VA
 * [Moneris](http://www.moneris.com/) - CA
 * [Moneris (US)](http://www.monerisusa.com/) - US
 * [MoneyMovers](http://mmoa.us/) - US
@@ -162,7 +161,7 @@ The [ActiveMerchant Wiki](http://github.com/activemerchant/active_merchant/wikis
 * [NETPAY Gateway](http://www.netpay.com.mx) - MX
 * [NMI](http://nmi.com/) - US
 * [Ogone](http://www.ogone.com/) - BE, DE, FR, NL, AT, CH
-* [Omise](https://www.omise.co/) - TH
+* [Omise](https://www.omise.co/) - TH, JP
 * [Openpay](Openpay) - MX
 * [Optimal Payments](http://www.optimalpayments.com/) - CA, US, GB
 * [Orbital Paymentech](http://chasepaymentech.com/) - US, CA
@@ -210,7 +209,6 @@ The [ActiveMerchant Wiki](http://github.com/activemerchant/active_merchant/wikis
 * [SecurePayTech](http://www.securepaytech.com/) - NZ
 * [SecurionPay](https://securionpay.com/) - AD, AE, AF, AG, AI, AL, AM, AO, AR, AS, AT, AU, AW, AX, AZ, BA, BB, BD, BE, BF, BG, BH, BI, BJ, BL, BM, BN, BO, BR, BS, BT, BV, BW, BY, BZ, CA, CC, CD, CF, CG, CH, CI, CK, CL, CM, CN, CO, CR, CU, CV, CW, CX, CY, CZ, DE, DJ, DK, DM, DO, DZ, EC, EE, EG, EH, ER, ES, ET, FI, FJ, FK, FM, FO, FR, GA, GB, GD, GE, GF, GG, GH, GI, GL, GM, GN, GP, GQ, GR, GS, GT, GU, GW, GY, HK, HM, HN, HR, HT, HU, ID, IE, IL, IM, IN, IO, IQ, IR, IS, IT, JE, JM, JO, JP, KE, KG, KH, KI, KM, KN, KP, KR, KW, KY, KZ, LA, LB, LC, LI, LK, LR, LS, LT, LU, LV, LY, MA, MC, MD, ME, MF, MG, MH, MK, ML, MM, MN, MO, MP, MQ, MR, MS, MT, MU, MV, MW, MX, MY, MZ, NA, NC, NE, NF, NG, NI, NL, NO, NP, NR, NU, NZ, OM, PA, PE, PF, PG, PH, PK, PL, PM, PN, PR, PS, PT, PW, PY, QA, RE, RO, RS, RU, RW, SA, SB, SC, SD, SE, SG, SH, SI, SJ, SK, SL, SM, SN, SO, SR, ST, SV, SY, SZ, TC, TD, TF, TG, TH, TJ, TK, TL, TM, TN, TO, TR, TT, TV, TW, TZ, UA, UG, UM, US, UY, UZ, VA, VC, VE, VG, VI, VN, VU, WF, WS, YE, YT, ZA, ZM, ZW
 * [SkipJack](http://www.skipjack.com/) - US, CA
-* [SoEasyPay](http://www.soeasypay.com/) - US, CA, AT, BE, BG, HR, CY, CZ, DK, EE, FI, FR, DE, GR, HU, IE, IT, LV, LT, LU, MT, NL, PL, PT, RO, SK, SI, ES, SE, GB, IS, NO, CH
 * [Spreedly](https://spreedly.com) - AD, AE, AT, AU, BD, BE, BG, BN, CA, CH, CY, CZ, DE, DK, EE, EG, ES, FI, FR, GB, GI, GR, HK, HU, ID, IE, IL, IM, IN, IS, IT, JO, KW, LB, LI, LK, LT, LU, LV, MC, MT, MU, MV, MX, MY, NL, NO, NZ, OM, PH, PL, PT, QA, RO, SA, SE, SG, SI, SK, SM, TR, TT, UM, US, VA, VN, ZA
 * [Stripe](https://stripe.com/) - AT, AU, BE, CA, CH, DE, DK, ES, FI, FR, GB, IE, IT, LU, NL, NO, SE, SG, US
 * [Swipe](https://www.swipehq.com/checkout) - CA, NZ

Rakefile

@@ -13,6 +13,7 @@ require 'rake'
 require 'rake/testtask'
 require 'support/gateway_support'
 require 'support/ssl_verify'
+require 'support/ssl_version'
 require 'support/outbound_hosts'
 require 'bundler/gem_tasks'
 
@@ -28,14 +29,12 @@ task :test => 'test:units'
 namespace :test do
   Rake::TestTask.new(:units) do |t|
     t.pattern = 'test/unit/**/*_test.rb'
-    t.ruby_opts << '-rubygems -w'
     t.libs << 'test'
     t.verbose = true
   end
 
   Rake::TestTask.new(:remote) do |t|
     t.pattern = 'test/remote/**/*_test.rb'
-    t.ruby_opts << '-rubygems -w'
     t.libs << 'test'
     t.verbose = true
   end
@@ -91,8 +90,15 @@ namespace :gateways do
     end
   end
 
-  desc 'Test that gateways allow SSL verify_peer'
-  task :ssl_verify do
-    SSLVerify.new.test_gateways
+  namespace :ssl do
+    desc 'Test that gateways allow SSL verify_peer'
+    task :verify do
+      SSLVerify.new.test_gateways
+    end
+
+    desc 'Test gateways minimal SSL version connection'
+    task :min_version do
+      SSLVersion.new.test_gateways
+    end
   end
 end

activemerchant.gemspec

@@ -14,14 +14,14 @@ Gem::Specification.new do |s|
   s.homepage = 'http://activemerchant.org/'
   s.rubyforge_project = 'activemerchant'
 
-  s.required_ruby_version = '>= 2'
+  s.required_ruby_version = '>= 2.3'
 
   s.files = Dir['CHANGELOG', 'README.md', 'MIT-LICENSE', 'CONTRIBUTORS', 'lib/**/*', 'vendor/**/*']
   s.require_path = 'lib'
 
   s.has_rdoc = true if Gem::VERSION < '1.7.0'
 
-  s.add_dependency('activesupport', '>= 3.2.14', '< 5.1')
+  s.add_dependency('activesupport', '>= 4.2', '< 8')
   s.add_dependency('i18n', '>= 0.6.9')
   s.add_dependency('builder', '>= 2.1.2', '< 4.0.0')
   s.add_dependency('nokogiri', "~> 1.4")

gemfiles/rails.6.0.gemfile

@@ -0,0 +1,14 @@
+source "https://rubygems.org"
+
+gem "activesupport", "~> 6.0"
+gem "rexml", ">= 3.2.4"
+
+gem 'jruby-openssl', :platforms => :jruby
+
+group :test, :remote_test do
+  # gateway-specific dependencies, keeping these gems out of the gemspec
+  gem 'braintree', '~> 2.78.0'
+  gem "psych", "< 4"
+end
+
+gemspec path: "../"

gemfiles/rails.6.1.gemfile

@@ -0,0 +1,14 @@
+source "https://rubygems.org"
+
+gem "activesupport", "~> 6.1"
+gem "rexml", ">= 3.2.4"
+
+gem 'jruby-openssl', :platforms => :jruby
+
+group :test, :remote_test do
+  # gateway-specific dependencies, keeping these gems out of the gemspec
+  gem 'braintree', '~> 2.78.0'
+  gem "psych", "< 4"
+end
+
+gemspec path: "../"

gemfiles/rails.7.0.gemfile

@@ -0,0 +1,15 @@
+source "https://rubygems.org"
+
+gem "activesupport", "~> 7.0"
+gem "rexml", ">= 3.2.4"
+
+gem 'jruby-openssl', :platforms => :jruby
+
+group :test, :remote_test do
+  # gateway-specific dependencies, keeping these gems out of the gemspec
+  gem 'braintree', '~> 2.78.0'
+  gem "psych", "< 4"
+end
+
+
+gemspec path: "../"

generators/gateway/templates/remote_gateway_test.rb

@@ -43,7 +43,7 @@ def test_successful_authorize_and_capture
 
     assert capture = @gateway.capture(@amount, auth.authorization)
     assert_success capture
-    assert_equal 'REPLACE WITH SUCCESS MESSAGE', response.message
+    assert_equal 'REPLACE WITH SUCCESS MESSAGE', capture.message
   end
 
   def test_failed_authorize

lib/active_merchant.rb

@@ -28,11 +28,6 @@
 require 'active_support/core_ext/object/conversions'
 require 'active_support/core_ext/class/attribute'
 require 'active_support/core_ext/enumerable'
-
-if(!defined?(ActiveSupport::VERSION) || (ActiveSupport::VERSION::STRING < "4.1"))
-  require 'active_support/core_ext/class/attribute_accessors'
-end
-
 require 'active_support/core_ext/module/attribute_accessors'
 
 require 'base64'
@@ -42,6 +37,7 @@
 require 'rexml/document'
 require 'timeout'
 require 'socket'
+require 'openssl'
 
 require 'active_merchant/network_connection_retries'
 require 'active_merchant/connection'

lib/active_merchant/billing/credit_card.rb

@@ -176,21 +176,20 @@ def requires_verification_value?
       # @return [String]
       attr_accessor :icc_data
 
-      # Returns or sets a fallback reason for a EMV transaction whereby the customer's card entered a fallback scenario.
-      # This can be an arbitrary string.
+      # Returns or sets information about the source of the card data.
       #
       # @return [String]
-      attr_accessor :fallback_reason
-
-      # Returns or sets whether card-present EMV data has been read contactlessly.
-      #
-      # @return [true, false]
-      attr_accessor :contactless_emv
-
-      # Returns or sets whether card-present magstripe data has been read contactlessly.
-      #
-      # @return [true, false]
-      attr_accessor :contactless_magstripe
+      attr_accessor :read_method
+
+      READ_METHOD_DESCRIPTIONS = {
+        nil => 'A card reader was not used.',
+        'fallback_no_chip' => 'Magstripe was read because the card has no chip.',
+        'fallback_chip_error' => "Magstripe was read because the card's chip failed.",
+        'contactless' => 'Data was read by a Contactless EMV kernel. Issuer script results are not available.',
+        'contactless_magstripe' => 'Contactless data was read with a non-EMV protocol.',
+        'contact' => 'Data was read using the EMV protocol. Issuer script results may follow.',
+        'contact_quickchip' => 'Data was read by the Quickchip EMV kernel. Issuer script results are not available.',
+      }
 
       # Returns the ciphertext of the card's encrypted PIN.
       #
@@ -245,7 +244,7 @@ def last_name?
       #
       # @return [String] the full name of the card holder
       def name
-        [first_name, last_name].compact.join(' ')
+        "#{first_name} #{last_name}".strip
       end
 
       def name=(full_name)

lib/active_merchant/billing/credit_card_methods.rb

@@ -14,7 +14,9 @@ module CreditCardMethods
         'dankort'            => /^5019\d{12}$/,
         'maestro'            => /^(5[06-8]|6\d)\d{10,17}$/,
         'forbrugsforeningen' => /^600722\d{10}$/,
-        'laser'              => /^(6304|6706|6709|6771(?!89))\d{8}(\d{4}|\d{6,7})?$/
+        'laser'              => /^(6304|6706|6709|6771(?!89))\d{8}(\d{4}|\d{6,7})?$/,
+        'sodexo'             => /^(606071|603389|606070|606069|606068|600818)\d{8}$/,
+        'vr'                 => /^(627416|637036)\d{8}$/
       }
 
       # http://www.barclaycard.co.uk/business/files/bin_rules.pdf