Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option.mkvUseIndex to use index to skip Matroska cluster elements #2219

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Aug 15, 2024

Change EBML iterator and Matroksa parser so that, that it processes the metadata found in elements during parsing, rather then when the entire file is parsed.

Adds flag options.mkvUseIndex, which is by default: false, if set to true, in Matroska based files, use the SeekHead element index to skip segment/cluster elements..
experimental functionality
Can have a significant performance impact if enabled.
Possible side effect can be that certain metadata maybe skipped, depending on the index.
If there is no SeekHead element present in the Matroska file, this flag has no effect.

Related technical information: Matroska: Data Layout

Related to:

Resolves: #2135

@Borewit Borewit self-assigned this Aug 15, 2024
@coveralls
Copy link

Coverage Status

coverage: 97.092% (+0.03%) from 97.061%
when pulling 1b9a88c on skip-matroska-cluster-elements-using-index
into 1fe4049 on master.

@Borewit Borewit merged commit 1a713b7 into master Aug 15, 2024
25 checks passed
@Borewit Borewit deleted the skip-matroska-cluster-elements-using-index branch August 15, 2024 16:24
@Borewit Borewit changed the title Add `option.mkvUseIndex to use index to skip Matroska cluster elements Add option.mkvUseIndex to use index to skip Matroska cluster elements Aug 15, 2024
@Borewit
Copy link
Owner Author

Borewit commented Aug 15, 2024

Part of v10.2.0

@Borewit Borewit linked an issue Sep 11, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to avoid parsing entire Matroska file? Parsing WebM consumes a lot of CPU and is slow
2 participants