-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run database tests in CI #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momentiris
force-pushed
the
test-foo-fix
branch
5 times, most recently
from
November 20, 2024 14:05
befba4c
to
0785fc4
Compare
momentiris
force-pushed
the
test-foo-fix
branch
2 times, most recently
from
December 9, 2024 14:18
5b031a3
to
38a0d52
Compare
momentiris
force-pushed
the
test-foo-fix
branch
from
December 10, 2024 16:00
1b9a6f5
to
6b44830
Compare
driatic
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to remark on, looks great!
momentiris
force-pushed
the
test-foo-fix
branch
from
December 18, 2024 14:10
2753961
to
316fe93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withContext
test helper that wraps each test in a db transaction and rollbacks after test finishwithContext
db
as param to adapter functions instead of them referencing the export themselves.At first I thought running in transactions like this would allow us to parallelize tests but unfortunately not.. yet.
Something about how mssql works with transactions which I don't understand yet.
Todo:
Investigate what this does and if it's problematic to use in test and not in prod.
ALTER DATABASE [tenants-leases-test] SET READ_COMMITTED_SNAPSHOT ON;
It allows us to run multiple jest workers for the db tests that now run in transactions.