Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTH-164: review status and housing type types #187

Merged
merged 14 commits into from
Jan 13, 2025

Conversation

momentiris
Copy link
Contributor

@momentiris momentiris commented Dec 11, 2024

Adjust code based on Bostads-AB-Mimer/onecore-types#136

Also refactor housing reference logic quite a bit.
Revised specifications made it make more sense to just tie the application profile and housing reference tighter together.
I decided to just always create and update both profile and housing reference since they cannot exist separately from each other.

Copy link

linear bot commented Dec 11, 2024

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detta är väl tillagt i onecore-types nu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, när den branchen i types mergas så 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha just det. Jag tänkte i mitt huvud att den redan var mergad men det är den såklart inte 😂

@mittistormen
Copy link
Contributor

Adjust code based on Bostads-AB-Mimer/onecore-types#136

Also refactor housing reference logic quite a bit. Revised specifications made it make more sense to just tie the application profile and housing reference tighter together. I decided to just always create and update both profile and housing reference since they cannot exist separately from each other.

Utan att veta exakt vad som ändrats i kraven så tycker jag det låter vettigt att uppdatera profile och reference tillsammans och betrakta dom som en enhet. Jag har haft "på känn" att vi kommer landa där

@momentiris momentiris changed the base branch from main to develop-uthyrning-bostader January 13, 2025 13:23
@momentiris momentiris merged commit 637156e into develop-uthyrning-bostader Jan 13, 2025
1 check passed
@momentiris momentiris deleted the uth-164 branch January 13, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants