Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip xp_regread if we don't have sa perms #3426

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

erikdarlingdata
Copy link
Contributor

closes #3425

Copy link
Member

@BrentOzar BrentOzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! Looks good, merging into the dev branch, will be in the next release with credit to you in the release notes.

@BrentOzar BrentOzar added this to the 2024-03 Release milestone Feb 16, 2024
@BrentOzar BrentOzar merged commit 8affa4c into BrentOzarULTD:dev Feb 16, 2024
1 check passed
@Montro1981
Copy link
Contributor

@erikdarlingdata the issue I had with this is that check 211 ran mostly fine on my limited permission box, and xp_regread did work for the most part, that was the reason why I chose the solution that I build before ;-)

@erikdarlingdata
Copy link
Contributor Author

erikdarlingdata commented Feb 22, 2024

@Montro1981 Yeah, I still couldn’t run it without error in the limited permissions environment I was in, which is why I did this. If you want to do a more granular permissions check, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sp_Blitz - Skip xp_regread when @sa is set to 0
3 participants