Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Fixed internal link for sp_BlitzQueryStore #3439

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

ReeceGoding
Copy link
Contributor

@ReeceGoding ReeceGoding commented Feb 17, 2024

The hyperlink for the table of contents for sp_BlitzQueryStore appears broken. This fixes it.

It may also be the case that the "Like BlitzCache, for Query Store" tagline needs changing, but I'm not sure if that or the section heading of "How Has a Query Plan Changed Over Time" should be used. My opinion is that the second of the two should be used. I find that sp_BlitzQueryStore will return the same query on multiple rows even if it only has one plan (and throw a "Multiple Plans" warning at the same time), whereas sp_BlitzCache never does. The "How Has a Query Plan Changed Over Time" heading is more faithful to this (because the extra rows are for different time intervals), but the very first line of the docs for sp_BlitzQueryStore advertises it as similar to sp_BlitzCache so I'm not sure which job sp_BlitzQueryStore is actually intended to do. See issue #3440 .

Copy link
Member

@BrentOzar BrentOzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! Looks good, merging into the dev branch.

@BrentOzar BrentOzar merged commit 98c0df5 into BrentOzarULTD:dev Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants