Update sp_DatabaseRestore.sql #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@RunStoredProcAfterRestore should not be inside the @TestRestore check
|
@BrentOzar - suspect there's a bug in the change you made. If the plan is to run this for any situation, then the stored proc should run whether |
|
Sorry about that! That's weird, I just did a search/replace on the parameter name and edited a description. |
|
I had it inside the @TestRestore because when I wrote the original change it was only going to run if you were doing a test. Your change to make it always run makes sense but means it should move outside that block. All good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RunStoredProcAfterRestore should not be inside the @TestRestore check