Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: file type check ignores classes #852

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Conversation

BrettMayson
Copy link
Owner

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.0%. Comparing base (71f685f) to head (9c9ff26).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
libs/config/src/analyze/lints/c11_file_type.rs 71.4% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/config/src/analyze/lints/c11_file_type.rs 65.0% <71.4%> (+14.1%) ⬆️

@PabstMirror
Copy link
Collaborator

ace has ~800 warnings for the allow_no_extension change, but it's also easy enough to turn off

@BrettMayson
Copy link
Owner Author

BrettMayson commented Dec 20, 2024

They're all legit though? Some evening I could slap extensions on them. This PR should remove all the class ones, are there other false positives?

@PabstMirror
Copy link
Collaborator

I didn't notice any

Another possible issue would be if someone was doing dev builds with wav/png and then did final builds with wss/paa
Such that they want no extensions in the configs
but again they can just turn off the feature

@BrettMayson
Copy link
Owner Author

Ah, I suppose, I've never done that

@BrettMayson BrettMayson merged commit b04abe1 into main Dec 26, 2024
37 checks passed
@BrettMayson BrettMayson deleted the c11_ignore_no_backslashes branch December 26, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config: filetype warnings - False Positives
2 participants