Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template error reporting improvements #561

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Template error reporting improvements #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8f9940a
Upgrade outdated.
ghinda Dec 10, 2024
504b2c9
Bump version.
ghinda Dec 10, 2024
332f3f4
Show handlebars compilation errors like missing partial or missing
ghinda Dec 10, 2024
f856425
Fix issues with not restoring the correct focus when opening the dialog
ghinda Dec 10, 2024
023de2b
Insert templates in linkedin messaging with the paste-editor.
ghinda Dec 10, 2024
9ac90a0
Tweak inserting templates on linkedin in text fields with quill.
ghinda Dec 10, 2024
fce2611
Formatting for the linkedin plugin.
ghinda Dec 10, 2024
a0b50b5
Upgrade outdated.
ghinda Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
583 changes: 305 additions & 278 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "briskine",
"version": "7.14.0",
"version": "7.14.1",
"description": "Write everything faster.",
"private": true,
"type": "module",
Expand Down
14 changes: 7 additions & 7 deletions src/content/dialog/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,6 @@ function Dialog (originalProps) {
e.stopPropagation()
e.preventDefault()

// cache selection details, to restore later
const selection = getSelection(node)
anchorNode = selection.anchorNode
anchorOffset = selection.anchorOffset
focusNode = selection.focusNode
focusOffset = selection.focusOffset

// cache editor,
// to use for inserting templates or restoring later.
editor = document.activeElement
Expand All @@ -177,6 +170,13 @@ function Dialog (originalProps) {
editor = editor.shadowRoot.activeElement
}

// cache selection details, to restore later
const selection = getSelection(editor)
anchorNode = selection.anchorNode
anchorOffset = selection.anchorOffset
focusNode = selection.focusNode
focusOffset = selection.focusOffset

word = getSelectedWord({
element: editor
})
Expand Down
Loading
Loading