Review Task 2 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrtqKr
reviewed
Mar 24, 2020
| import java.text.SimpleDateFormat; | ||
| import java.util.Date; | ||
|
|
||
| public class AbstractComment { |
There was a problem hiding this comment.
Myląca nazwa, może sugerować że klasa jest abstrakcyjna
| public Type getType() { | ||
| return type; | ||
| } | ||
|
|
There was a problem hiding this comment.
Po co zwracać niesformatowaną datę w getterze
| protected String getAuthor() { | ||
| return author; | ||
| } | ||
|
|
There was a problem hiding this comment.
Enum zadeklarowany na drugim końcu pliku, kiedy Type wykorzystywane jest na początku
| @@ -0,0 +1,4 @@ | |||
| package pl.fracz.mcr.comment; | |||
|
|
|||
| public class CommentNotAddedException extends Exception { | |||
There was a problem hiding this comment.
???????? Pusta klasa dziedzicząca po exception
| public class Comment extends AbstractComment { | ||
| private String text; | ||
|
|
||
| private File file; |
There was a problem hiding this comment.
Nazwa powinna mówić po co jest określona zmienna, file niewiele mówi ale mogłoby być wykorzystywane np w iteracji kiedy wynika z kontekstu
| public static SourceFile createFromString(String sourceCode, String language) { | ||
| return new SourceFile(sourceCode, language); | ||
| } | ||
|
|
| */ | ||
| public static SourceFile createFromFile(File sourceFile) throws IOException { | ||
| String sourceCode = FileUtils.read(sourceFile); | ||
| return createFromString(sourceCode, FileUtils.getExtension(sourceFile.getName())); |
| } | ||
|
|
||
| public void addTextComment(String comment) throws CommentNotAddedException { | ||
| if (selectedLine == null) { |
|
|
||
| // public void addVideoComment(File videoFile) throws CommentNotAddedException { | ||
| // } | ||
|
|
There was a problem hiding this comment.
Niejednolite nazewnictwo, parametr bool
| return code; | ||
| } | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find as many defects and problems as possible!
You can skip the
Line.javaas you have already saw it in the Task 1.