Added Volley to Singleton

BudhirajaMadhav · May 29, 2021 · 506f569 · 506f569
1 parent 330dc34
commit 506f569
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 4 deletions.
diff --git a/.idea/misc.xml b/.idea/misc.xml
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
diff --git a/app/build.gradle b/app/build.gradle
@@ -38,7 +38,7 @@ dependencies {
 
     implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
     implementation 'androidx.core:core-ktx:1.3.2'
-    implementation 'androidx.appcompat:appcompat:1.2.0'
+    implementation 'androidx.appcompat:appcompat:1.3.0'
     implementation 'com.google.android.material:material:1.3.0'
     implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
     testImplementation 'junit:junit:4.13.2'

diff --git a/app/src/main/java/com/androidmadhav/litmemes/MainActivity.kt b/app/src/main/java/com/androidmadhav/litmemes/MainActivity.kt
@@ -39,7 +39,6 @@ class MainActivity : AppCompatActivity() {
 
 
     private fun loadMeme(){
-        val queue = Volley.newRequestQueue(this)
         val url = "https://meme-api.herokuapp.com/gimme"
         progressBar.visibility = View.VISIBLE
         val jsonObjectRequest = JsonObjectRequest(
@@ -79,7 +78,8 @@ class MainActivity : AppCompatActivity() {
         ) { error ->
             Toast.makeText(this, "Image Loading Failed! Please try after sometime.", Toast.LENGTH_SHORT).show()
         }
-        queue.add(jsonObjectRequest)
+
+        MySingleton.getInstance(this).addToRequestQueue(jsonObjectRequest)
 
 
     }

diff --git a/app/src/main/java/com/androidmadhav/litmemes/MySIngleton.kt b/app/src/main/java/com/androidmadhav/litmemes/MySIngleton.kt
@@ -0,0 +1,27 @@
+package com.androidmadhav.litmemes
+
+import android.content.Context
+import com.android.volley.Request
+import com.android.volley.RequestQueue
+import com.android.volley.toolbox.Volley
+
+class MySingleton constructor(context: Context) {
+    companion object {
+        @Volatile
+        private var INSTANCE: MySingleton? = null
+        fun getInstance(context: Context) =
+            INSTANCE ?: synchronized(this) {
+                INSTANCE ?: MySingleton(context).also {
+                    INSTANCE = it
+                }
+            }
+    }
+    private val requestQueue: RequestQueue by lazy {
+        // applicationContext is key, it keeps you from leaking the
+        // Activity or BroadcastReceiver if someone passes one in.
+        Volley.newRequestQueue(context.applicationContext)
+    }
+    fun <T> addToRequestQueue(req: Request<T>) {
+        requestQueue.add(req)
+    }
+}