Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dates handling #121

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Refactor dates handling #121

wants to merge 7 commits into from
+140 −906

Conversation

leclairm
Copy link
Contributor

@leclairm leclairm commented Feb 6, 2025 •
edited
Loading

Fix #119, #97 and incidentally #108

Short summary: essentially remove as many None as possible from date related attributes in order to make the code more understandable.

Methods

  • Insert dedicated classes to test types instead of testing for None
  • Move some logic to the yaml models although it was already argued against once

Parts to treat

  • Previous _WhenBasemodel
  • ConfigCycle

@leclairm leclairm linked an issue Feb 6, 2025 that may be closed by this pull request
possibility of None for date related variables #119
Open
@leclairm leclairm linked an issue Feb 6, 2025 that may be closed by this pull request
Specify type of parameters more explicit #108
Open
@leclairm leclairm changed the title None dates refactor Refactor dates handling Feb 6, 2025
@leclairm leclairm linked an issue Feb 6, 2025 that may be closed by this pull request
confusing start and end dates for cycles, tasks and ICON #97
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@leclairm