Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51 bug datatrail pull on canfar doesnt set group #52

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

tjzegmott
Copy link
Contributor

  • fix(init): set valid choices for datatrail config init
  • fix(pull): set group permissions if site is canfar

Description

Related Issue

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tjzegmott tjzegmott requested a review from MWSammons January 8, 2024 20:53
@tjzegmott tjzegmott linked an issue Jan 8, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (fa94b90) 77.73% compared to head (5e3b966) 77.44%.
Report is 7 commits behind head on main.

Files Patch % Lines
dtcli/ps.py 41.66% 7 Missing ⚠️
dtcli/src/functions.py 70.58% 5 Missing ⚠️
tests/test_functions.py 88.57% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   77.73%   77.44%   -0.29%     
==========================================
  Files          12       13       +1     
  Lines         952     1011      +59     
==========================================
+ Hits          740      783      +43     
- Misses        212      228      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MWSammons
Copy link
Contributor

MWSammons commented Jan 9, 2024

@tjzegmott On the fix(pull) because the linting failed the testing step was skipped, are there actually any tests that would have run for this code?

@tjzegmott
Copy link
Contributor Author

@MWSammons That's right, since it failed at the linting it skipped the tests. However, in the later commit (5e3b966) both the linting and tests passed.

@MWSammons
Copy link
Contributor

Oh right, of course.

@tjzegmott tjzegmott merged commit 7f2fa63 into main Jan 9, 2024
2 checks passed
@tjzegmott tjzegmott deleted the 51-bug-datatrail-pull-on-canfar-doesnt-set-group branch January 9, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Datatrail pull on CANFAR doesn't set group
3 participants