Colour contrast for accessibility #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the lighthouse score for accessibility was 91.
To improve this score, I targeted the displayed warning regarding colour contrast. In particular, poor colour contrast was present in the "search" button and "view details" link button that was displayed on the main dashboard page. These issues were repaired by:
identifying the associated HTML class and id attributes of the buttons that were causing the accessibility issues
locating the file controlling the style rules for the front-end website, which was discovered to largely be controlled by the base.css file, located at Mayan-EDMS/mayan/apps/appearance/static/appearance/css
applying the necessary colour fixes using the class attributes of the problematic buttons
This change increased the accessibility lighthouse score by 2, taking it from 91 to 93.