Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Added lots of javadoc and cleaned up some code. #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

- Added lots of javadoc and cleaned up some code. #58

wants to merge 1 commit into from

Conversation

Raiyankr
Copy link
Collaborator

@Raiyankr Raiyankr commented Dec 9, 2022

  • Added Javadoc for all my parts :)
  • Cleaned up some of the code to remove code smells

@Raiyankr Raiyankr requested review from khushil-sketch, SoySerhio507, qwet1235 and tanverzahed and removed request for khushil-sketch December 9, 2022 03:23
qwet1235
qwet1235 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@qwet1235 qwet1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good documentation! It makes it very easy to follow the code.

kevinzshen
kevinzshen approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@kevinzshen kevinzshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation looks great! Thank you for adding so much, it makes our code much easier to understand.

SoySerhio507
SoySerhio507 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@SoySerhio507 SoySerhio507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwet1235 qwet1235 qwet1235 approved these changes

@SoySerhio507 SoySerhio507 SoySerhio507 approved these changes

@kevinzshen kevinzshen kevinzshen approved these changes

@tanverzahed tanverzahed Awaiting requested review from tanverzahed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Raiyankr @kevinzshen @SoySerhio507 @qwet1235