-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for maui #923
Merged
Merged
Add tests for maui #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dont save code coverage results
dont save code coverage results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 17 changed files in this pull request and generated no suggestions.
Files not reviewed (11)
- src/Caliburn.Micro.Maui.Tests/Caliburn.Micro.Maui.Tests.csproj: Language not supported
- src/Caliburn.Micro.Maui/Caliburn.Micro.Maui.csproj: Language not supported
- src/Caliburn.Micro.sln: Language not supported
- src/Caliburn.Micro.Maui.Tests/AssemblyCacheTests.cs: Evaluated as low risk
- src/Caliburn.Micro.Maui.Tests/FormsPlatformProviderTests.cs: Evaluated as low risk
- src/Caliburn.Micro.Maui.Tests/ActionMessageTests.cs: Evaluated as low risk
- src/Caliburn.Micro.Platform/Platforms/Maui/Parameter.cs: Evaluated as low risk
- src/Caliburn.Micro.Platform/Platforms/Maui/ActionMessage.cs: Evaluated as low risk
- src/Caliburn.Micro.Platform.Tests/ViewModelLocatorTests.cs: Evaluated as low risk
- src/Caliburn.Micro.Platform.Tests/ViewLocatorTests.cs: Evaluated as low risk
- src/Caliburn.Micro.Maui.Tests/ViewLocatorTests.cs: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a suite of unit tests for the
Caliburn.Micro.Maui
project and updates the project configuration. The changes include adding new test classes, updating the project file to include necessary packages and settings, and modifying access levels in theActionMessage
class.Unit Tests Addition:
ActionMessageTests
: Added tests to verify theMethodName
,Handler
, andParameters
properties ofActionMessage
. (src/Caliburn.Micro.Maui.Tests/ActionMessageTests.cs
)AssemblyCacheTests
: Added tests to ensure adding the same assembly multiple times and resetting the cache does not throw exceptions. (src/Caliburn.Micro.Maui.Tests/AssemblyCacheTests.cs
)FormsPlatformProviderTests
: Added tests to verify the behavior ofFormsPlatformProvider
methods. (src/Caliburn.Micro.Maui.Tests/FormsPlatformProviderTests.cs
)Project Configuration:
Caliburn.Micro.Maui.Tests.csproj
: Created a new test project file with references to necessary packages and project dependencies. (src/Caliburn.Micro.Maui.Tests/Caliburn.Micro.Maui.Tests.csproj
)Caliburn.Micro.Maui.csproj
: Updated the language version to 10.0 and added anInternalsVisibleTo
attribute for the test project. (src/Caliburn.Micro.Maui/Caliburn.Micro.Maui.csproj
) [1] [2]Codebase Changes:
ActionMessage.cs
: Changed the access level of theHandler
property setter fromprivate
tointernal
. (src/Caliburn.Micro.Platform/Platforms/Maui/ActionMessage.cs
)These changes collectively enhance the test coverage for the
Caliburn.Micro.Maui
project and ensure that the project is configured correctly for testing.Closes #877