Refactor code and update test coverage settings #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor Parameter.cs and XamlMetadataProvider.cs for consistent style: - Add braces for all control structures - Add spaces around operators and after commas - Rename method parameters for clarity - Replace AvaloniaProperty with DependencyProperty - Improve XML documentation comments Update unit test step to use coverage.runsettings: - Replace previous coverage command with --settings coverage.runsettings Remove step to restore NuGet packages for the tutorial Add coverage.runsettings for code coverage configuration: - Use XPlat code coverage data collector - Configure JSON format for coverage report
1 task
There was a problem hiding this comment.
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (2)
- coverage.runsettings: Language not supported
- .github/workflows/dotnet.yml: Evaluated as low risk
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Simplified the CreateXamlMember method by removing the unused variable `userType`. The result of `GetXamlTypeByName("Caliburn.Micro.View")` is now discarded using the discard operator `_`, indicating that the result is not needed for further processing.
There was a problem hiding this comment.
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (2)
- coverage.runsettings: Language not supported
- .github/workflows/dotnet.yml: Evaluated as low risk
1 task
vb2ae
deleted the
945-fix-code-scanning-alert-missed-ternary-opportunity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the code formatting and configuration of the project. The most important changes include modifying the unit test configuration to use a settings file, adding a new
coverage.runsettingsfile, and reformatting various classes to follow a consistent coding style.Configuration changes:
.github/workflows/dotnet.yml: Updated the unit test command to use--settings coverage.runsettingsinstead of specifying coverage parameters directly.coverage.runsettings: Added a new settings file to configure code coverage collection in JSON format.Code formatting:
src/Caliburn.Micro.Platform/Platforms/net46-netcore/Parameter.cs: Reformatted theParameterclass to follow a consistent coding style by placing opening braces on a new line. [1] [2] [3] [4]src/Caliburn.Micro.Platform/Platforms/uap/Parameter.cs: Applied the same formatting changes to theParameterclass as in thenet46-netcoreversion. [1] [2] [3]src/Caliburn.Micro.Platform/Platforms/uap/XamlMetadataProvider.cs: Reformatted theXamlMetadataProviderandXamlTypeInfoProviderclasses for consistent brace placement and improved readability. [1] [2] [3] [4] [5] [6] [7]Closes #945