Skip to content

Commit

Permalink
Finish writeup
Browse files Browse the repository at this point in the history
  • Loading branch information
Cameron Fraser committed Mar 23, 2019
1 parent 950b750 commit 4388bc8
Show file tree
Hide file tree
Showing 11 changed files with 65 additions and 247 deletions.
307 changes: 61 additions & 246 deletions P1.ipynb

Large diffs are not rendered by default.

Binary file modified test_images_output/solidWhiteCurve.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test_images_output/solidWhiteRight.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test_images_output/solidYellowCurve.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test_images_output/solidYellowCurve2.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test_images_output/solidYellowLeft.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test_images_output/whiteCarLaneSwitch.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test_videos_output/challenge.mp4
Binary file not shown.
Binary file modified test_videos_output/solidWhiteRight.mp4
Binary file not shown.
Binary file modified test_videos_output/solidYellowLeft.mp4
Binary file not shown.
5 changes: 4 additions & 1 deletion writeup/writeup.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,5 +101,8 @@ Lastly we use a weighted image addition to overlay the green lines onto the imag

## Possible Improvements

There seems to be a lot of noise that gets picked up near the top of the region mask which can lead to some line data that matches slope threshold to get put in the lane line lists which throws off the average by quite a bit. I think a possible solution would be to create a threshold on positional data as well to ensure there are no outliers.

## Conclusion
A region mask seems error prone due to different points where a camera could be fixed on a vehicle. I would assume that in a real scenario if a region mask is being used then the code would have more information about its position off the ground and on the vehicle and orientation angle so region boundaries could be calculated dynamically.

The challenge video has two problems. One is the heavy line curvature in the road and the other is the shadows. Fitting a curve to the data points might be a better choice and exploring additional denoising techniques.

0 comments on commit 4388bc8

Please sign in to comment.