Skip to content

Commit

Permalink
builtins/internal_object: check get/set does not change
Browse files Browse the repository at this point in the history
test262: 44.23% (+0.04) | 🧪 48414 | 🤠 21413 (+18) | ❌ 7474 (-24) | 💀 17400 (+6) | 🏗️ 162 | 💥 300 | ⏰ 28 | 📝 1637
  • Loading branch information
CanadaHonk committed Sep 22, 2024
1 parent b32cfa2 commit 48df87a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions compiler/builtins/_internal_object.ts
Original file line number Diff line number Diff line change
Expand Up @@ -469,10 +469,10 @@ export const __Porffor_object_define = (obj: any, key: any, value: any, flags: i
let err: boolean = false;

// descriptor type (accessor/data) and/or flags (other than writable) have changed
if ((tail & 0b0111) != (flags & 0b0111)) err = true;

if (!err && (tail & 0b1001) == 0) {
// data descriptor and already non-writable only checks
if ((tail & 0b0111) != (flags & 0b0111)) {
err = true;
} else if ((tail & 0b1000) == 0) {
// already non-writable only checks
// trying to change writable false -> true
if (flags & 0b1000) {
err = true;
Expand Down
4 changes: 2 additions & 2 deletions compiler/builtins_precompiled.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "porffor",
"description": "a basic experimental wip aot optimizing js -> wasm engine/compiler/runtime in js",
"version": "0.43.0+e3142bb67",
"version": "0.43.1+1c54b6982",
"author": "CanadaHonk",
"license": "MIT",
"scripts": {},
Expand Down
2 changes: 1 addition & 1 deletion runner/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env node
import fs from 'node:fs';
globalThis.version = '0.43.0+e3142bb67';
globalThis.version = '0.43.1+1c54b6982';

// deno compat
if (typeof process === 'undefined' && typeof Deno !== 'undefined') {
Expand Down
2 changes: 1 addition & 1 deletion test262/history.json

Large diffs are not rendered by default.

0 comments on commit 48df87a

Please sign in to comment.