Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future proofing mana base for 4 color generated decks #6730

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Future proofing mana base for 4 color generated decks #6730

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
999eb18
Future proofing mana base for 4 color generated decks
GroundThing Dec 30, 2024
a5632fb
Merge branch 'master' into patch-1
GroundThing Dec 30, 2024
54476ac
Merge branch 'master' into patch-1
GroundThing Dec 31, 2024
c460b4f
Merge branch 'master' into patch-1
tehdiplomat Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions forge-gui-mobile/src/forge/adventure/util/CardUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,21 +590,25 @@ else if(landName.size()==4)
RewardData sub2= new RewardData(base);
RewardData sub3= new RewardData(base);
RewardData sub4= new RewardData(base);
sub1.count/=5;
sub2.count/=5;
sub3.count/=5;
sub4.count/=5;
RewardData sub5= new RewardData(base);
sub1.count/=6;
sub2.count/=6;
sub3.count/=6;
sub4.count/=6;
sub5.count/=6;
base.count-=sub1.count;
base.count-=sub2.count;
base.count-=sub3.count;
base.count-=sub4.count;
base.count-=sub5.count;

base.subTypes = new String[]{landName.get(0),landName.get(1)};
sub1.subTypes = new String[]{landName.get(0),landName.get(2)};
sub2.subTypes = new String[]{landName.get(0),landName.get(3)};
sub3.subTypes = new String[]{landName.get(1),landName.get(2)};
sub4.subTypes = new String[]{landName.get(1),landName.get(3)};
rewards.addAll(Arrays.asList(sub1,sub2,sub3,sub4));
sub5.subtypes = new String[]{landName.get(2),landName.get(3)};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this? The tests fail, and there's a typo here (the t in subtypes isn't capitalized)

rewards.addAll(Arrays.asList(sub1,sub2,sub3,sub4,sub5));
}
else if(landName.size()==5)
{
Expand Down
Loading