Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra cost gift rework #6733

Merged
merged 7 commits into from
Jan 5, 2025
Merged

Extra cost gift rework #6733

merged 7 commits into from
Jan 5, 2025

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Dec 31, 2024 •
edited
Loading

  • Used PromisedGift in xCount
  • moved chooseOptionalCosts into SpellAbilityAi (so it can be used later)
  • Check for Invalid Targets if cost would be added
  • Update SpellAbilityAi cases for when it should use OptionalCost or not (this is probably for PromisedGift specific)

@Hanmac Hanmac added Game Mechanics AI General AI tag labels Dec 31, 2024
@Hanmac Hanmac force-pushed the extraCostGiftRework branch from 4a7e319 to 0c9794d Compare January 4, 2025 20:54
@Hanmac
Copy link
Contributor Author

Hanmac commented Jan 4, 2025

@tool4ever i used AITgts for these 2 cards which have 0.1 and 1.0 targets to stop it from using it on Targets where Additional Cost is not needed

@Hanmac Hanmac requested review from tool4ever and Agetian January 4, 2025 21:01
@Agetian
Copy link
Contributor

Agetian commented Jan 5, 2025

Looks like a nice effort, thanks! 👍

@Hanmac Hanmac marked this pull request as ready for review January 5, 2025 07:52
@Hanmac Hanmac merged commit 2fcf95c into master Jan 5, 2025
7 checks passed
@Hanmac Hanmac deleted the extraCostGiftRework branch January 5, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agetian Agetian Agetian approved these changes

@tehdiplomat tehdiplomat Awaiting requested review from tehdiplomat

@tool4ever tool4ever Awaiting requested review from tool4ever

Assignees
No one assigned
Labels
AI General AI tag Game Mechanics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hanmac @Agetian @tool4ever