templates: fix issues with spaces #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMichka
force-pushed
the
test-print
branch
12 times, most recently
from
d0a11a1 to
7b51283
Compare
iMichka
changed the title
iMichka
force-pushed
the
test-print
branch
2 times, most recently
from
160d78b to
c51a68b
Compare
iMichka
force-pushed
the
test-print
branch
3 times, most recently
from
09364fb to
0636b4f
Compare
iMichka
changed the title
I have seen different scenarios regarding spaces in templates. On some platforms there might be spaces, on some others not. The biggest changes are in: src/pygccxml/parser/scanner.py -> replace spaces that are actually coming from the xml file src/pygccxml/declarations/pattern_parser.py -> remove spaces Of course all the tests had to be adjusted This "might" be a breaking change if you used to compare declarations manually, but from a pygccxml point of view all comparisons / search functions are still working as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen different scenarios regarding spaces in templates.
On some platforms there might be spaces, on some others not.
The biggest changes are in:
src/pygccxml/parser/scanner.py -> replace spaces that are actually coming from the xml file
src/pygccxml/declarations/pattern_parser.py -> remove spaces
Of course all the tests had to be adjusted
This "might" be a breaking change if you used to compare declarations manually,
but from a pygccxml point of view all comparisons / search functions are still
working as before.