feat(#379): confirm exit from playground #515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YonatanKra
reviewed
Oct 14, 2020
|
@czerwinskilukasz1 looks like @km4 is taking care of #379 that you have raised :) |
YonatanKra
reviewed
Oct 19, 2020
|
@mhagmajer I see the light in the tunnel :P |
|
@mhagmajer some update, check now and add feedback |
mhagmajer
suggested changes
Nov 2, 2020
| if (dirty) return; | ||
| playgroundIsDirty(!dirty); | ||
| dirty = true; | ||
| }); |
There was a problem hiding this comment.
I think that now when we have isDirty check, we can just attach onbeforeunload once for all without the need for the extra playgroundIsDirty function.
Suggested change
| }); | |
| }); | |
| window.onbeforeunload = function (e: any) { | |
| if (isDirty) { | |
| e.preventDefault(); | |
| e.returnValue = ''; | |
| } | |
| }; |
| @@ -81,6 +87,7 @@ async function executeAskScript( | |||
| const json = await response.json(); | |||
| if (response.status == 200) { | |||
| showSuccessfulResponse(json.result); | |||
| playgroundIsDirty(false); | |||
There was a problem hiding this comment.
Suggested change
| playgroundIsDirty(false); | |
| isDirty = false; |
There was a problem hiding this comment.
@mhagmajer
what about this isDirty flag? Now is undefined variable for this scope. If I push dirty params to all functions eg.
async function executeAskScript(
askScriptCode: string,
askScriptServerUrl: string,
isDirty: boolean
) {
executeAskScriptFromEditor(editor, askScriptServerUrl, isDirty); the flag dosnt update in the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #379