Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: direct download button ✨ #35

Closed
wants to merge 11 commits into from
Closed

added: direct download button ✨ #35

wants to merge 11 commits into from

Conversation

lisztomania23
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for youthful-ride-1733ce ready!

Name Link
🔨 Latest commit 66468ca
🔍 Latest deploy log https://app.netlify.com/sites/youthful-ride-1733ce/deploys/655d2524d07dee0008cbe596
😎 Deploy Preview https://deploy-preview-35--youthful-ride-1733ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@TheLastProject TheLastProject left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks pretty neat.

The "Catima is a community project" text sometimes touches the border of the background a bit much, but that's a minor thing.

I do worry a bit about how, on small screens like phones, the way the direct download button is next to the Google Play button it may confuse people in thinking it's Google Play. Maybe it should be a full-size button instead with the text "Direct Download" or something on it? That way nobody can ever get confused and it'll move to a new line on mobile automatically

image

_layouts/default.html Outdated Show resolved Hide resolved
@lisztomania23
Copy link
Contributor Author

lisztomania23 commented Nov 21, 2023

#7 instead of changing direct download button, added dialog warning on clicking it. tried changing size but it was breaking layout.
#33 positioned both download icon and contribute text for small screen

@TheLastProject
Copy link
Member

I appreciate your work but I don't think it solves the issue, it is still super easy for people to get confused and think the download icon is for Google Play.

I played around with it a bit (to add a button for IzzyOnDroid) and it seems it should be much easier to add an extra button now at the end without breaking the layout since #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants