Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Pricing" Section Updated Alignments #104

Open
wants to merge 3 commits into
base: website
Choose a base branch
from
Open

"Pricing" Section Updated Alignments #104

wants to merge 3 commits into from

Conversation

iamRabia-N
Copy link

This PR contains the updated code of the "Pricing" Section Alignments. This PR is the result of the following issue:
[New Feature_WebApp] - Pricing Section Text Alignment #103

Closes #103

Proposed Changes

Alignment of the content in center to make this section's alignment consistent with the overall website.

Type of Change

  • New Feature (Landing Page)
  • New Feature (App)
  • Bug (Landing Page)
  • Bug (App)
  • New Component (App)
  • Enhancement
  • Documentation / ReadMe / Workflows
  • Other (If not in above options):

Your Idea for Level (GSSoC)

  • Level 1
  • Level 2
  • Level 3

Screenshots (if applicable)

github-readme pr

praveenscience
praveenscience requested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@praveenscience praveenscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the library files.

css/bootstrap.min.css Outdated Show resolved Hide resolved
@iamRabia-N
Copy link
Author

Hi @praveenscience
I have reverted commit but both files are removed. Now is it okay if I'll share new commit (with no modification in library files) in the same branch or should I go with new branch?

@praveenscience
Copy link
Member

I guess so. How did you manage to pull up a PR that contains no changed files? 🤣 @iamRabia-N

@praveenscience
Copy link
Member

Oh, you reverted the whole commit? 🤯

@iamRabia-N
Copy link
Author

Those 2 files were together under one commit. Reverting commit removed both files.

@iamRabia-N
Copy link
Author

Hi @praveenscience
Kindly review the latest commit with name "Updated Pricing Section" which contains the modified code related to the issue.

@iamRabia-N
Copy link
Author

@praveenscience Kindly review the changes and share your feedback

@iamRabia-N
Copy link
Author

@praveenscience Kindly review the changes and share your feedback

@praveenscience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenscience praveenscience praveenscience requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamRabia-N @praveenscience