Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colour Scheme #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Colour Scheme #113

wants to merge 1 commit into from

Conversation

anushkachauhxn
Copy link

Issue that this pull request solves

Closes: #105

Proposed changes

Changed the color scheme of website to black and gold.

  • Black (#000)
  • Gold (#B29155)
  • Cream background (#ECE9E1)
  • White (#FFF)

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe): Changed colors

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

praveenscience
praveenscience requested changes Mar 13, 2022
View reviewed changes
src/styles/_header.scss
Comment on lines +16 to +24

.navbar .btn {
background: #B29155;
color: #000;
font-weight: 500;
}
.navbar .btn:focus {
box-shadow: none;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have these converted into SCSS please? 😊

src/styles/App.scss
@@ -1,6 +1,6 @@
body {
font-family: "Montserrat", sans-serif;
background-color: #e0e8e5;
background-color: #ECE9E1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase colour names please. 😊

@praveenscience
Copy link
Member

Updates?

@anushkachauhxn
Copy link
Author

I'll make another commit to fix these changes today.

@praveenscience
Copy link
Member

Any updates? 😊

@github-actions github-actions bot added the has conflicts Damnnn these conflicts! :( label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenscience praveenscience praveenscience requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
has conflicts Damnnn these conflicts! :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color scheme of the website
2 participants
@anushkachauhxn @praveenscience