Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-5076] oaipmh slowness #819

Merged
merged 2 commits into from
May 22, 2024
Merged

[ENG-5076] oaipmh slowness #819

merged 2 commits into from
May 22, 2024

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented May 21, 2024 •
edited by jira bot
Loading

speed up the oai-pmh database query

  • add indexes on LatestIndexcardRdf.modified and Indexcard.deleted
  • make a few small subqueries separately, to reduce query planning complexity

ENG-5076

@coveralls
Copy link

coveralls commented May 21, 2024 •
edited
Loading

Coverage Status

coverage: 89.616% (+0.01%) from 89.606%
when pulling d909fc6 on aaxelb:fix/oaipmh-slowness
into 5813016 on CenterForOpenScience:develop.

@aaxelb aaxelb marked this pull request as ready for review May 21, 2024 19:36
@aaxelb aaxelb force-pushed the fix/oaipmh-slowness branch from 4c7ae12 to d909fc6 Compare May 22, 2024 13:47
mfraezz
mfraezz approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@aaxelb aaxelb merged commit 2a0283b into CenterForOpenScience:develop May 22, 2024
3 checks passed
@aaxelb aaxelb deleted the fix/oaipmh-slowness branch May 22, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfraezz mfraezz mfraezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaxelb @coveralls @mfraezz