Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6508] fix: two few adapters #829

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Oct 31, 2024

smooth out some hacks to work with slightly updated django-allauth

(in allauth, "oauth2 adapters" and "social account adapters" are different things with overlapping name that (by happenstance, previously) were non-overlapping enough they could be merged into a single subclass without much problem -- alas, no longer)

@coveralls
Copy link

Coverage Status

coverage: 90.656% (+0.05%) from 90.611%
when pulling 90436b6 on aaxelb:fix/6508-oauth-login
into 9ac4cc9 on CenterForOpenScience:develop.

@aaxelb aaxelb marked this pull request as ready for review October 31, 2024 18:54
@aaxelb aaxelb requested a review from mfraezz October 31, 2024 19:12
Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice if there were tests, but since this is effectively just configuring a third-party library, makes sense that there wouldn't be.

Pass complete :octocat:

@aaxelb aaxelb merged commit 8b39c69 into CenterForOpenScience:develop Nov 4, 2024
3 checks passed
@aaxelb aaxelb deleted the fix/6508-oauth-login branch November 4, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants