Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6189] denorm fixes/followup #831

Merged
merged 5 commits into from
Nov 13, 2024
Merged

[ENG-6189] denorm fixes/followup #831

merged 5 commits into from
Nov 13, 2024

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Nov 13, 2024 •
edited
Loading

follow-up to #828

  • fix trovesearch_denorm error loading related property counts (with tests)
  • improve trovesearch_denorm's handling of removed values:
    • add chunk_timestamp field
    • instead of deleting all value-docs before each chunk, use chunk_timestamp to delete only the value-docs not
      updated after each chunk
    • add tests for de-indexing cards and values
  • remove some dead code

@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Coverage Status

coverage: 91.191% (+0.05%) from 91.14%
when pulling f5b2169 on aaxelb:fix/denorm-followup
into d6d5774 on CenterForOpenScience:develop.

@aaxelb aaxelb force-pushed the fix/denorm-followup branch from 84502d5 to f5b2169 Compare November 13, 2024 19:30
@aaxelb aaxelb changed the title Fix/denorm followup [ENG-6189] denorm fixes/followup Nov 13, 2024
@aaxelb aaxelb marked this pull request as ready for review November 13, 2024 19:36
@aaxelb aaxelb merged commit adb4dfe into CenterForOpenScience:develop Nov 13, 2024
3 checks passed
@aaxelb aaxelb deleted the fix/denorm-followup branch November 13, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfraezz mfraezz mfraezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaxelb @coveralls @mfraezz