[ENG-6654] fixfix: correct misunderstanding, handle conflicts #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaxelb
force-pushed
the
fix/indexer-fallback-failure
branch
2 times, most recently
from
8f54393 to
99f3eb2
Compare
- messages can _only_ be ack'd thru the channel they were received by -- trying to recover a channel to ack thru does nothing - handle easily-detectable delete_by_query conflicts in a followup celery task (so the indexer doesn't fall over on it)
aaxelb
force-pushed
the
fix/indexer-fallback-failure
branch
from
99f3eb2 to
adc9b83
Compare
aaxelb
changed the title
try avoiding connection errors when calling `message.ack()` -- do a bit more book-keeping to know when a bulk elastic action is the last for its index-card, so it can ack immediately then instead of waiting 'til the whole chunk has completed
mfraezz
approved these changes
Dec 5, 2024
| 'card_pks': messages_chunk.target_ids_chunk, | ||
| 'timestamp': messages_chunk.timestamp, | ||
| }, | ||
| countdown=3, # TODO: config? |
There was a problem hiding this comment.
Minor: Should probably be configurable, yes.
Something like
settings.ELASTICSEARCH['COUNTDOWN_DELAY'] = int(os.environ.get('ELASTICSEARCH_COUNTDOWN_DELAY', 3))
would probably be reasonable
There was a problem hiding this comment.
went with ELASTICSEARCH_POST_INDEX_DELAY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure_ack,ack_callback) -- messages can only be ack'd thru the channel they were received by, so trying to recover a channel to ack thru does nothingdaemonuser to access elastic8message.ack()-- do a bit more book-keeping to know when a bulk elastic action is the last for its index-card, so it can ack immediately then instead of waiting 'til the whole chunk has completed