Feature/Handle nested dataverses[PLAT-1328]

[pattisdr]

Purpose

We're getting a Key Error if someone has a nested dataverse inside of a dataverse when connecting a dataset. thanks @felliott for pointing me towards the fix.

Changes

On the Dataset.id property, when looping through the contents of a dataverse, verify that the resource type is a "dataset" before attempting to access the "protocol" key.

To Duplicate

Create a test dataverse on https://demo.dataverse.org/, and then add both a dataverse and a dataset to that top-level dataverse. (Create the nested dataverse first).

So I had dataverse Grapes Dataverse, with a Raisins Dataverse and a strawberries dataset.

On the OSF connect your Grapes Dataverse, select your strawberries dataset and hit save. Before, you would get a key error when the _id property would loop through all the content in Grapes Dataverse (Raisins Dataverse and strawberries dataset). If it hit a dataverse before finding the matching dataset, it would get an error when looking for the protocol key which doesn't exist on a dataverse.

Ticket

https://openscience.atlassian.net/browse/PLAT-1328

[felliott]

LGTM, but, alas, I don't have a commit bit for this repo!

@pattisdr, do you mind also submitting this to upstream, as well? I filed an issue at IQSS#50 Thank you!

Cheers,
@felliott

[pattisdr]

Submitted PR here! IQSS#51

[pdurbin]

@pattisdr @felliott thanks! Upstream we just merged IQSS#51

[pattisdr]

hooray @pdurbin!

[pattisdr]

Closing as this work was merged upstream.