Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-5257] Rename "internal foo" to "foo reference" #13

Merged
merged 3 commits into from
Feb 8, 2024
Merged

[ENG-5257] Rename "internal foo" to "foo reference" #13

merged 3 commits into from
Feb 8, 2024

Conversation

aaxelb
Copy link
Collaborator

@aaxelb aaxelb commented Feb 8, 2024 •
edited
Loading

first commit is to pass pre-commit -- updated flake8 config to ignore long lines (trust black to handle it and decide when to make exceptions)

rename

files moved:

  • addon_service/internal_user/
  • addon_service/internal_resource/
  • addon_service/tests/test_by_type/test_internal_user.py
  • addon_service/tests/test_by_type/test_internal_reference.py

variations replaced

  • "internal_user"
  • "InternalUser"
  • "internaluser"
  • "internal-user"
  • "internal user"
  • (and similar for internal resource)

ENG-5257

aaxelb added 3 commits February 8, 2024 09:04
@aaxelb
passing pre-commit
b4e870f
@aaxelb
(wip) move files
273b505 
internal_user to user_reference
internal_resource to resource_reference

(in-file updates coming next)
@aaxelb
resource reference, user reference
20d8faf
brianjgeiger
brianjgeiger approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The things I see look good, and it compiles and tests pass, so should be fairly complete.

@jwalz jwalz merged commit e3eddfe into develop Feb 8, 2024
2 checks passed
@aaxelb aaxelb deleted the rename/internal_foo/foo_reference branch February 13, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaxelb @brianjgeiger @jwalz