Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6895] added django-silk as core dependency and not dev one #204

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions app/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,14 @@
"django.middleware.clickjacking.XFrameOptionsMiddleware",
]

# run under ASGI locally:
INSTALLED_APPS.insert(0, "daphne") # django's reference asgi server
ASGI_APPLICATION = "app.asgi.application"

if DEBUG and not env.TESTING:
# add django-silk to enable profiling
INSTALLED_APPS.append("silk")
MIDDLEWARE.insert(0, "silk.middleware.SilkyMiddleware")
if DEBUG:
# run under ASGI locally:
INSTALLED_APPS.insert(0, "daphne") # django's reference asgi server
ASGI_APPLICATION = "app.asgi.application"


ROOT_URLCONF = "app.urls"
Expand Down Expand Up @@ -174,7 +173,6 @@
},
}

SILKY_PYTHON_PROFILER = True
DATABASE_ROUTERS = ["addon_service.osf_models.db_router.OsfDatabaseRouter"]

REST_FRAMEWORK = {
Expand Down
2 changes: 1 addition & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ pyjwe = "1.0.0"
cryptography = "42.0.7"
boto3 = "1.34"
boa-api = "^0.1.14"
django-silk = "^5.3.2"


[tool.poetry.group.dev.dependencies]
Expand All @@ -32,7 +33,6 @@ flake8 = "^7.1.1"
isort = "^5.13.2"
pre-commit = "^3.8.0"
pdoc = "14.5.1"
django-silk = "^5.3.2"

[tool.poetry.group.release.dependencies]
sentry-sdk = "2.7.1"
Expand Down
Loading