Fix select_top_level_subject() method

base/expected_conditions.py

@@ -1,3 +1,5 @@
+from selenium.common.exceptions import StaleElementReferenceException
+from selenium.webdriver.remote.webdriver import WebDriver
 from selenium.webdriver.support import expected_conditions as EC
 
 
@@ -25,3 +27,20 @@ def __init__(self, page_index):
 
     def __call__(self, driver):
         return len(driver.window_handles) > self.page_index
+
+
+class text_to_be_present_in_elements(object):
+    """ An expectation for checking if the given text is present in the
+    specified element.
+    locator, text
+    """
+    def __init__(self, locator, text_):
+        self.locator = locator
+        self.text = text_
+
+    def __call__(self, driver: WebDriver):
+        try:
+            element_texts = [element.text for element in driver.find_elements(*self.locator)]
+            return any([self.text in element_text for element_text in element_texts])
+        except StaleElementReferenceException:
+            return False

pages/preprints.py

@@ -1,9 +1,13 @@
+import time
 from urllib.parse import urljoin
 
+import ipdb
 import pytest
 from selenium.webdriver.common.by import By
+from selenium.webdriver.support.wait import WebDriverWait
 
 import settings
+from base.expected_conditions import text_to_be_present_in_elements
 from base.locators import (
     ComponentLocator,
     GroupLocator,
@@ -113,13 +117,12 @@ def select_from_dropdown_listbox(self, selection):
     )
 
     def select_top_level_subject(self, selection):
+        subject_selector = 'div[data-analytics-scope="Browse"] > ul > li'
+        wait = WebDriverWait(self.driver, 20)
+        wait.until(text_to_be_present_in_elements((By.CSS_SELECTOR, subject_selector), selection))
         for subject in self.top_level_subjects:
             if subject.text == selection:
-                # Find the checkbox element and click it to select the subject
-                checkbox = subject.find_element_by_css_selector(
-                    'input.ember-checkbox.ember-view'
-                )
-                checkbox.click()
+                subject.click()
                 break
 
     first_selected_subject = Locator(By.CSS_SELECTOR, 'li[data-test-selected-subject]')