Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our package only has major.minor version naming. #11663

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Our package only has major.minor version naming. #11663

merged 3 commits into from
Dec 1, 2023

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Dec 1, 2023

No description provided.

jjhembd
jjhembd reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do occasionally have a patch release. For example, next week we might have 1.112.1. Wouldn't this cut script republish the '.0' zip?

@mramato
Copy link
Contributor Author

mramato commented Dec 1, 2023

@jjhembd Great point, when I tested this I think it was against a .1 version so the zip worked locally. I used the sed suggestion you made offline, which looks cleaner and would only ever be a problem if we got to .10, which means some other crazy stuff happened 😄

@jjhembd
Copy link
Contributor

jjhembd commented Dec 1, 2023

Thanks, your comment made me worry about 1.200... so I escaped the . in the sed pattern to be safe

@jjhembd jjhembd merged commit de76f2f into main Dec 1, 2023
5 checks passed
@jjhembd jjhembd deleted the fix-production-deploy branch December 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjhembd jjhembd jjhembd left review comments

Assignees

@jjhembd jjhembd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mramato @jjhembd